GrapheneForms: Smallcombo allows limited interactivity when "enabled":false

[timcortesi]

It appears that there remains some limited interactive functionality on "smallcombo" form fields even when "enabled" is set to false.

See the attached example. In that situation, there is a "file" type which, when the down arrow is clicked, allows some limited interaction. You can't actually change the value, but it has lead to some user confusion thinking that the field is in fact editable (when it is not).

Here's another example of a normal smallcombo which is not editable:

[alikemaltanriverdi]

The same behavior is also valid for the User type fields. Please see the additional comments below:

Description These bugs are currently in the production.

When a SmallCombo type and User type field are set as not-editable field in their conditions, they're still editable field and they look like enabled fields. If the section that has smallcombo box or user in it is set as a non-editable, then they both look like disabled, such as a non-editable hover item, etc, but they can be selected, edited, etc.

Feature / Subsystem This is in the form of the workflows.

To Reproduce

1. Go to a workflow or an app, such as https://my.binghamton.edu/admin/workflows/57 , https://my.binghamton.edu/admin/apps/278
2. Select a user type field and smallcombo type field and set "Editable" condition to "Never" or some other condition.
3. Save the workflow/ app and go to app/ workflow to observe.
4. Go to form builder of the workflow one more time to make condition of the "Edit" of the section they are located into "Never" and observe the form.

Console Errors None

Link(s)

1. Open the DEV instance of the following workflow that is in Workflow(Dev) group: https://my.binghamton.edu/admin/workflows/57
2. https://my.binghamton.edu/admin/apps/278

Additional context Workflow form example:

Note: In the screenshot above: Student: User type field that has edit condition as "if _flowstate -> not matches -> origin or Save For Later" Degree and Program: Smallcombo type field that has edit condition as "if ->_flowstate -> not matches -> origin or Save For Later" I also tried changing the condition to "Never" but it was acting the same. App form example:

If you need additional links/ explanation, you can contact to me @alikemaltanriverdi

[timcortesi]

@Cloverstone -- Are you able to "fix" this issue in Graphene without doing a full patch to the underlying gform library? We're having issues with this, as effectively any combobox in any workflow is editable, even when it appears that it is not. We have a couple workflows which will require this to be addressed in the next couple weeks. (April 15th)

[Cloverstone]

I have had a fix in development for a while - I will look into the possibility of it being a stand alone patch.

On Mon, Mar 29, 2021 at 3:54 PM Tim Cortesi @.***> wrote:

@Cloverstone https://github.com/Cloverstone -- Are you able to "fix" this issue in Graphene without doing a full patch to the underlying gform library? We're having issues with this, as effectively any combobox in any workflow is editable, even when it appears that it is not. We have a couple workflows which will require this to be addressed in the next couple weeks. (April 15th)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EscherLabs/Graphene/issues/98#issuecomment-809668131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMBGELHMRQSXLAR5XYAWZDTGDLGLANCNFSM4U5A3OIA .

[timcortesi]

@Cloverstone yeah -- that's what I had thought, but a standalone patch would be great given the current reality. thanks.

[alikemaltanriverdi]

@Cloverstone it seems like this issue had been resolved, you can close this issue anytime you'd like. I just tested it in the production, and it was behaving as expected for both the workflows and the microapps