search

EshanTrivedi21 / Git-CheatSheet

An opensource initiative to which over 37 individuals from all over the world collaborated in order to streamline the process of learning Git and GitHub.
https://eshantrivedi21.github.io/Git-CheatSheet/
MIT License
51 stars 54 forks source link

Light/Dark mode Toggle Button (Website) #25

Closed EshanTrivedi21 closed 1 year ago

EshanTrivedi21 commented 1 year ago

A button needs to be added on the website that toggles between the light and the dark mod, this would increase the reader's readability and user-experience.. Keep in mind that the format is same as the Website's Theme

shrutilenka commented 1 year ago

Hey @EshanTrivedi21, I am interested in working on this issue. Could you please assign this to me?

EshanTrivedi21 commented 1 year ago

Heyy Sure! @shrutilenka I'll assign it to you, Thanks for your interest.

EshanTrivedi21 commented 1 year ago

any progress @shrutilenka ??

EshanTrivedi21 commented 1 year ago

@aryan-parmar

shrutilenka commented 1 year ago

@EshanTrivedi21 yes I'm working on that. will be submitting it by tomorrow.

EshanTrivedi21 commented 1 year ago

greatt!! okay thanks.

EshanTrivedi21 commented 1 year ago

@shrutilenka please reference your pull request here!!

EshanTrivedi21 commented 1 year ago

@shrutilenka i need to close this issue.. also to count in as a contributor you need to reference your pull request here.. please do it asap.. many thanks :)

shrutilenka commented 1 year ago

39

@EshanTrivedi21 this is my pull request.

EshanTrivedi21 commented 1 year ago

@shrutilenka seems like the toggle button isn't working on mobiles Or maybe only on my phone Are you facing the same issue?

shrutilenka commented 1 year ago

@EshanTrivedi21 let me check once again...

shrutilenka commented 1 year ago

lightmode darkmode

@EshanTrivedi21 sir the toggle button is working in mobile view. its is not responsive but it is working.

EshanTrivedi21 commented 1 year ago

@shrutilenka It has topped working on the Pc as well.. here is the latest site: https://eshantrivedi21.github.io/Git-CheatSheet/ check it out here! @Aatmaj-Zephyr

EshanTrivedi21 commented 1 year ago

maybe what you have is your fork of the repository, there have been many additions and subtractions and commits after that one.. check it out once!

shrutilenka commented 1 year ago

@EshanTrivedi21 okay sir i am fixing the issue by tonight.

shrutilenka commented 1 year ago

@shrutilenka It has topped working on the Pc as well.. here is the latest site: https://eshantrivedi21.github.io/Git-CheatSheet/ check it out here! @Aatmaj-Zephyr

50

Done sir!

EshanTrivedi21 commented 1 year ago

Great work @shrutilenka ! It might have been deleted in a Pr and would have been unnoticed by me.. Sorry. not an issue... Thanks :)

EshanTrivedi21 commented 1 year ago

Closing this issue