Search Button on Website

[EshanTrivedi21]

A Search button is needed on the website.. which allows easy and comfortable for the user to find commands than to scroll over all day long! Also this the functionality must be of competition with the local (CTRL + F) tag.. Please someone take over this issue.. Thanks :)

[riteshsoni123]

Hello @EshanTrivedi21 I would like to solve this issue. Can you please assign this to me?

[EshanTrivedi21]

Sure brother.. Take over! Thanks for the involvement :) Also don't worry much about the UI we can look after it later!

[Abhay5855]

hey @EshanTrivedi21 Can you Please assign me this issue?

[EshanTrivedi21]

Yes @Abhay5855, you can work on this issue with @riteshsoni123

[EshanTrivedi21]

@riteshsoni123 plz take charge!

[Abhay5855]

@riteshsoni123 I have also assigned the issue I guess we can work it out together , @EshanTrivedi21 thanks for assigning

[EshanTrivedi21]

Any progress @riteshsoni123 @Abhay5855 ?

[Abhay5855]

Yes Started working on it Kindly provide some more time

[EshanTrivedi21]

what's the progress?? @Abhay5855

[Abhay5855]

I have Implemented that need some time to add a search icon and functionality @EshanTrivedi21

[Abhay5855]

@EshanTrivedi21 I have added the search bar and the search icon as well it is responsive too, and when user scrolls down and clicks ctrl + f , it goes to the custom search bar and focus on it , Is there anything to add more or the issue was this much

[EshanTrivedi21]

Great work buddy!!! Keep up. Go on !!! @Abhay5855

[MSamiDev]

Hello @EshanTrivedi21 Can you assign me as well, I have already created search feature for it.

[EshanTrivedi21]

@Abhay5855 please look into the matter and review the changes made by @MSamiDev once, since you're already working on this issue.. I have reviewed these changes and they same to be fine.. please review the changes once so that I can accept it and you can further make the changes you want Great job guys with this @Abhay5855 @MSamiDev

[Abhay5855]

@EshanTrivedi21 Sure I will check once with @MSamiDev and let you know

[EshanTrivedi21]

@Abhay5855 do I merge the pr and then you can make tje necessary changes?

[Abhay5855]

@EshanTrivedi21 Sure you can do that as well no problem I have also created a PR for the same https://github.com/EshanTrivedi21/Git-CheatSheet/pull/77

[EshanTrivedi21]

which on do i accept? @Abhay5855

[EshanTrivedi21]

There are alot of conflicts coming in your pull request @Abhay5855 , sorting which would take like an hour, what i can do is merge @MSamiDev's pr and then you can change the things you want? this would minimize everyone's work

[MSamiDev]

Hello @Abhay5855 and @EshanTrivedi21,

@Abhay5855 do you have some suggested changes that you can make in my PR(Design, Functionality), Then @EshanTrivedi21 You can merge the PR and then @Abhay5855 can do the necessary changes.

[EshanTrivedi21]

yup i will go on with that @MSamiDev, @Abhay5855 plz make the changes you feel like.. great going guys 🚀🚀

[Abhay5855]

@MSamiDev Sure man

[Abhay5855]

@EshanTrivedi21 Sure you can go with @MSamiDev PR I will make the necessary changes in there if required.

[EshanTrivedi21]

@Abhay5855 I have merged @MSamiDev 's pr, please take a look and add a pr making the necessary changes

[Abhay5855]

@EshanTrivedi21 Yes sure I will do that

[Abhay5855]

@EshanTrivedi21 i have refactored the search bar and add some styling can you check once please https://github.com/EshanTrivedi21/Git-CheatSheet/pull/84