EshanTrivedi21 / Git-CheatSheet

An opensource initiative to which over 37 individuals from all over the world collaborated in order to streamline the process of learning Git and GitHub.
https://eshantrivedi21.github.io/Git-CheatSheet/
MIT License
51 stars 53 forks source link

Solving Minor UI Issues #99

Closed EshanTrivedi21 closed 2 years ago

EshanTrivedi21 commented 2 years ago

Making the UI look Uniform like the Majority of the Website!

g4m3r0 commented 2 years ago

I would like to work on this issue. Kindly assign me to it :).

EshanTrivedi21 commented 2 years ago

Which issue are you opting for (one or more) ? @g4m3r0

g4m3r0 commented 2 years ago

@EshanTrivedi21 first I would like to start working on the top three issues that you have pointed out.

EshanTrivedi21 commented 2 years ago

Cool go on with it @g4m3r0

g4m3r0 commented 2 years ago

@EshanTrivedi21 What do you think of that so far? It uses font awesome icons instead of images and the defined CSS theme for colouring. image image

EshanTrivedi21 commented 2 years ago

@g4m3r0

g4m3r0 commented 2 years ago

@EshanTrivedi21 I've created a pull request, can you please take a look at the changes that I've made?

g4m3r0 commented 2 years ago

@EshanTrivedi21 I just saw another UI issue in the first code box: image

Should it be that the icons turn blue when hovered? For me, that doesn't really fit with the rest of the site. image

What do you think about replacing the "copy" images of the boxes with fontawesome icons for more consistency? I can work on those issues too if you want.

EshanTrivedi21 commented 2 years ago

@g4m3r0 You can change the blue color issue, but I feel the copy button svg suits the best as it the common thing used wherever this copy button is used.. even github