EshikaP1 / Student2

MIT License
0 stars 0 forks source link

NTM Individual review #4

Open EshikaP1 opened 4 months ago

EshikaP1 commented 4 months ago

Here is the link to my video: https://drive.google.com/file/d/1w8RAuHLlzhRwu5xpgPCaR0BcOM33XAmf/view?usp=sharing Here is the link to my individual issue: https://eshikap1.github.io/Student2//2024/02/26/NTM_REVIEW.html

Key Commits: -Final backend code for drink: https://github.com/EshikaP1/2back/commit/f9743ce46528ff8332ec49e6f0a20cb2ec6abcc3 -Login commit: https://github.com/EshikaP1/2front/commit/46bdbc39d4b9523389db0609a6ee8d4f3f7247c8 -Another login commit: https://github.com/EshikaP1/2front/commit/d78d3eaef4aad660261473c38ef5dbbeaf447036 -Backend User code final: https://github.com/EshikaP1/2back/commit/2ae034879dd570a1fc6d6171e9cab3e79eeba265 -Deployment: https://github.com/EshikaP1/2back/commit/c0c029c0a060cd4e3652764f0c646415a01bdfe7 image

Nupurbb commented 4 months ago

Hi, you did a great job and I loved seeing your video! Here are some grows and glows: Glows: The database for your drinks on the backend The delete function on the page being able to add new drinks the calories apperaing for every drink after an input Glows: Adding more css changes to te=he background color Adding images of some drinks to make the page pop more adding an interactive drink game

Overall grear job, .98/1!!

cliang1 commented 4 months ago

Great job with the styling, the theme was consistent and engaging. I liked how your data was concise, so it was easy to understand what was happening in the code. The demonstration adding and deleting drinks from the database was also very clear.

Glows:

Overall Grade: 0.98/1.0

Aditi99b commented 4 months ago

0.96/1

The website is well formed fulfills all Collegeboard requirements. Authentication is implemented correctly, looking at the code. I recommend showing a redirect to custom error page on the video to demonstrate the functionality of the login authentication, but otherwise not much to be improved.