search

EskiMojo14 / keycaplendar

React app documenting current, future and past keycap GBs.
https://keycaplendar.firebaseapp.com/
MIT License
56 stars 6 forks source link

More filter options - Material, Manufacturer #50

Open mxmilkiib opened 3 years ago

mxmilkiib commented 3 years ago

I.e. into plastic, profile, etc.

EskiMojo14 commented 3 years ago

Adding more options for filtering/distinguishing sets by material and manufacturer is definitely something I've considered, but I'm not sure what the best approach would be.

Tracking profile, material, and manufacturer on a set by set basis, as keycapsets.com does, would require a large amount of work to go back and add the information to each existing set. On the other hand, having a separate database of profiles and corresponding material and manufacturer would definitely complicate matters.

It's still something I'll keep in mind, but it's pretty low priority in terms of things to add.

mxmilkiib commented 3 years ago

I'm referring to the existing data; given the 'Profile' filter section contains various "tags" that include ones solely for material types, others for profile type, and then for manufacturers. Could these not be separated visually to make it easier for the user?

EskiMojo14 commented 3 years ago

The current Profile field is entirely based on common usage - Cherry profile keycaps are referred to by their manufacturer, other profiles are referred to by name, and some profiles are available in both materials and thus are separated as such. It's all based on the natural way people refer to keycaps.

mxmilkiib commented 3 years ago

I agree, but you just naturally distinguished between three types yourself, ergo not "out there" for there being worth in slightly separating the list out; why not have all "only shape" filter options first, "only material" second, "combined material/shape" third, "manufacturer" fourth, or so?

I think I do understand though now that you are noting before that all the existing profile options are lumped in the one taxonomy set, so extra data entry (or advanced scraping) would be needed to separate those out in the DB.

But even if they are all in the same set behind the scenes, could the placement in the filter sidebar not be more distinguished?

EskiMojo14 commented 3 years ago

Separating them in the filter sidebar would be more confusing, in my personal opinion - I think it would imply that a set can be multiple things.

There aren't any profile names that are solely material based. The material is currently only added in the rare case where the same profile is available from the same manufacturer/vendor in both materials. (which currently only includes MT3)

I think it could be definitely useful for people who aren't familiar with all the profiles to have material and manufacturers noted somehow, but I don't think separating them in the sidebar is the right solution.

mxmilkiib commented 3 years ago

Sure thing. Thanks for the feedback and consideration.