Eskibear / vscode-extension-telemetry-wrapper

MIT License
2 stars 2 forks source link

Add capability to allow custom disabled telemetry list #43

Closed jdneo closed 2 years ago

jdneo commented 2 years ago
  1. The telemetry wrapper has its default disabled list
    • e.g. a RegExp: /path must include project and resource name: \/.*/gi
  2. There is an API to let users overwrite the list
Eskibear commented 2 years ago

how about I add API allowing you to register such patterns? E.g. addSensitvePattern(pattern: RegExp)

jdneo commented 2 years ago

Sounds good.

Eskibear commented 2 years ago

Instead of directly remove matched result, I'm thinking whether below proposal would be more powerful and flexible.

addReplacePattern(pattern: RegExp, replaceString: string)

E.g. Replace /path must include project and resource name: \/.*/gi with "path must include reousrce name" . Then you know what's redacted.

Eskibear commented 2 years ago

interesting, vscode-extension-telemetry@0.5.0 now also supports this... https://github.com/microsoft/vscode-extension-telemetry/releases/tag/v0.5.0