search

EskoSalaka / mtgtools

collection of tools for easy handling of Magic: The Gathering data on your computer
Other
65 stars 13 forks source link

Impossible to update Scryfall #15

Closed ciufflegend closed 2 years ago

ciufflegend commented 3 years ago

Hi, I cannot update scryfall, mtgio completly working. Here the traceback:

Processing responses: [695 / 831]Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/daniel/.local/lib/python3.8/site-packages/mtgtools/MtgDB.py", line 182, in scryfall_update process_scryfall_cards(current_sets, current_cards, verbose=verbose, workers=workers) File "/home/daniel/.local/lib/python3.8/site-packages/mtgtools/util/api_requests.py", line 167, in process_scryfall_cards ]) File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete return future.result() File "/home/daniel/.local/lib/python3.8/site-packages/mtgtools/util/api_requests.py", line 203, in process_cards await asyncio.sleep(0.1) File "/usr/lib/python3.8/asyncio/tasks.py", line 608, in _wait_for_one return f.result() # May raise f.exception(). File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run result = self.fn(*self.args, **self.kwargs) File "/home/daniel/.local/lib/python3.8/site-packages/mtgtools/util/api_requests.py", line 35, in process_card_page_response else: KeyError: 'data'

shcoops commented 3 years ago

Having a similar issue. Stuck processing responses between 40/831 and 700/831. Getting ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host.

AndrewWigman commented 3 years ago

Also having this issue, don't suppose anyone has figured it out in the past 6 months?

shcoops commented 3 years ago

@AndrewWigman I had the issue when I was pulling from the Pip directory. If you haven't already, try installing directly from GitHub and see if that resolves it, it worked for me.

EskoSalaka commented 2 years ago

Sorry guys, past year has been quite busy for me and I have not been able to update this project much at all! I know that some changes indeed are not yet in PIP.

It could also be that Scryfall API has changed a bit and it could be there are stricter limits on how much one can use the API. I know that they are at least offering a ZIP of all the cards, which would be a better way of updating the database.

Ill try to take a look soon...

shcoops commented 2 years ago

It worked perfectly when I imported from Git! Thanks

On Fri, Nov 19, 2021, 04:06 Esko-Kalervo Salaka @.***> wrote:

Sorry guys, past year has been quite busy for me and I have not been able to update this project much at all! I know that some changes indeed are not yet in PIP.

It could also be that Scryfall API has changed a bit and it could be there are stricter limits on how much one can use the API. I know that they are at least offering a ZIP of all the cards, which would be a better way of updating the database.

Ill try to take a look soon...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/EskoSalaka/mtgtools/issues/15#issuecomment-973885862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQJQXWKLRAMMUUFTLE6YMHDUMYHQXANCNFSM42CSAHVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

EskoSalaka commented 2 years ago

The fixes along with a new update method that uses the bulk data from Scryfall are now also in PYPI!