search

EsotericSoftware / kryonet

TCP/UDP client/server library for Java, based on Kryo
BSD 3-Clause "New" or "Revised" License
1.81k stars 416 forks source link

Java 8 support - Kryo 4.0.0 - JsonBeans 0.7 - Listener, Client and Server discovers refactored into an interface #118

Open Pyeroh opened 7 years ago

Pyeroh commented 7 years ago

It solves #77 and #39, by updating to Java 8 and using defender methods. It also removes unnecessary libs : you uses maven, and defines dependencies. Why maintaining dependencies in multiple places ?

I don't get why the diff marks there are differences between source files, as I didn't change tabs/spaces...

BTW, I think pushing an updated version of this lib on maven repositories would be great, as the only available version is a RC. Thanks for reviewing !

RobertZenz commented 7 years ago

I don't get why the diff marks there are differences between source files, as I didn't change tabs/spaces...

Smells like you accidentally changed the line-endings.

CookedApps commented 7 years ago

Hey @Pyeroh, does this pull include the fix for not recieving UDP on Android 5.0+ from #111?

Pyeroh commented 7 years ago

@CookedApps I did not tested, but I don't think so, sorry

sylvia43 commented 7 years ago

@CookedApps I just cherry picked my commit onto this and sent @Pyeroh a pull request. In the meantime, I'm using compile "com.github.anubiann00b:kryonet:6108b3b5" and https://jitpack.io/.