Open georgemavchun opened 9 years ago
Combining multiple fixes in the same PR makes review difficult. Please explain the fixes.
Should we delete that PR and resubmit few new? Or comments we have written is enough?
So what should we do now?
@NathanSweet Any news on this?
Splitting it into multiple PRs would help a lot.
Few bug fixes included. In each commit there is test that fails without fix commit and doesn't fail with it.