search

EsotericSoftware / spine-runtimes

2D skeletal animation runtimes for Spine.
http://esotericsoftware.com/
Other
4.41k stars 2.91k forks source link

[ts] 4.0.9 is the last working version #1968

Closed Andy1210 closed 3 years ago

Andy1210 commented 3 years ago

From 4.0.9 above the player is not rendering my animations, in debug view I can see the skeleton animating, but the images are simply not rendered at all.

4.0.9 image 4.0.14 image

Also version 4.1.0 published to npm is completely broken, in https://github.com/EsotericSoftware/spine-runtimes/blob/4.1-beta/spine-ts/spine-core/src/attachments/Sequence.ts it tries to import from "src" which is not ok in the dist of course.

badlogic commented 3 years ago

For 4.0, I'll need your skeleton and texture atlas images to fix the issue. The screenshots alone don't help I'm afraid.

Sorry for the 4.1 foobar, I'll fix that asap.

Andy1210 commented 3 years ago

Thank you. Here are the assets spine_assets.zip

badlogic commented 3 years ago

I've tried your assets with 4.0.14 directly from source and that renders correctly for me:

Screenshot 2021-10-14 at 16 12 17 Screenshot 2021-10-14 at 16 12 19

I've then replaced the locally compiled spine-webgl.js with the published one at https://unpkg.com/@esotericsoftware/spine-webgl@4.0.14/dist/iife/spine-webgl.js and that too works as intended (same result as above).

Do you have a public URL I can check out that demonstrates the issue?

(I've released a fixed 4.1.1 as well).

Andy1210 commented 3 years ago

hmm, now it's working for me as well 😅 I have no idea why. I've tried to install the v4.0.14 multiple times, and it was never working. Whenever I've rolled back to 4.0.9, it was fine. Now it's fine with 4.0.14 and I've tried now with 4.1.1 and it's fine as well.

Thanks for the quick fix for the 4.1. I think you can close this issue now.

badlogic commented 3 years ago

Awesome! Thanks for reporting the 4.1 issue as well!

On Thu, Oct 14, 2021, 16:37 Andy1210 @.***> wrote:

hmm, now it's working for me as well 😅 I have no idea why. I've tried to install the v4.0.14 multiple times, and it was never working. Whenever I've rolled back to 4.0.9, it was fine. Now it's fine with 4.0.14 and I've tried now with 4.1.1 and it's fine as well.

Thanks for the quick fix for the 4.1. I think you can close this issue now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/EsotericSoftware/spine-runtimes/issues/1968#issuecomment-943421918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5QBBXMDDBOPC6EKL4FOLUG3TLNANCNFSM5F7OKCYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.