search

EsotericSoftware / spine-runtimes

2D skeletal animation runtimes for Spine.
http://esotericsoftware.com/
Other
4.42k stars 2.92k forks source link

[cpp] skeletonJson version mismatch might cause a memory leak. #2622

Closed yakswa closed 2 months ago

yakswa commented 2 months ago

I already reported https://github.com/EsotericSoftware/spine-runtimes/issues/2563 and fixed

https://github.com/EsotericSoftware/spine-runtimes/blob/c9c6b9821163890c44ae142750afbed0826ad5e9/spine-cpp/spine-cpp/src/spine/SkeletonBinary.cpp#L121-L131

But that delete codes are need to apply SkeletonJson.cpp
root and skeletonData https://github.com/EsotericSoftware/spine-runtimes/blob/c9c6b9821163890c44ae142750afbed0826ad5e9/spine-cpp/spine-cpp/src/spine/SkeletonJson.cpp#L143-L161

thank you

badlogic commented 2 months ago

Sorry for the oversight. This is now fixed in the 4.2 branch.