search

EspecNorthAmerica / ChamberConnectLibrary

Python library for ESPEC North America chambers with P-300, SCP-220, Watlow F4, F4T controllers.
http://www.espec.com/na/support/software/
MIT License
30 stars 24 forks source link

Python3 support #13

Closed liambeguin closed 11 months ago

liambeguin commented 5 years ago

Hi,

python2 is approaching end of life and most of our setup is already on python3. This PR add python3 support and was tested on a WatlowF4T using TCP.

test:

$ cd ChamberConnectLibrary
$ virtualenv -p python3 venv3
$ venv3/bin/pip install .
$ source venv3/bin/activate
$ python3 bin/chamberconnectlibrary-test.py WatlowF4T TCP 192.168.100.59

[ ... ]

Testing Complete
liambeguin commented 5 years ago

Hi @MylesMetzler any chance you had a moment to look at this?

MylesMetzler commented 5 years ago

Sorry for the slow response. We use this library internally on a project that is still on using python 2.7 and is currently frozen pending a new release. After that release we can look into merging python 3 support.

I do intend to get to merging this when I am able.

liambeguin commented 5 years ago

okay, thanks.

maxballenger commented 4 years ago

Putting in another vote for Python3 compatibility. It should be possible to maintain compatibility with both. @Liambeguin do you think this is the case with your changes?

liambeguin commented 4 years ago

Hi @maxballenger, I don't remember testing this with python2 but reviewing the changes, it looks like it should still work. Unfortunately, I can't test this right now but if you can, I'd be happy to update the merge request.

liambeguin commented 4 years ago

Hi @MylesMetzler any updates on this merge request? Has your internal project been updated since last time?

MylesMetzler commented 4 years ago

@Liambeguin @PaulNongL is looking into python3 support I am not sure where it stands. I'll ask him.

liambeguin commented 4 years ago

Okay, thanks for the update

PaulNongL commented 4 years ago

It is half way through testing on P300. I have yet to go through with F4/F4T testing. I will notify you once all tests are complete and verified working on these controllers.

SimonL-Eno commented 3 years ago

Hi @MylesMetzler is there any update on this merge request? I would also like to use this in a python 3 project.

PaulNongL commented 3 years ago

Hi @MylesMetzler is there any update on this merge request? I would also like to use this in a python 3 project.

Hello Laim: We have a separate branch for Python3. https://github.com/EspecNorthAmerica/ChamberConnectLibrary/tree/dev_python3