search

EspressoSystems / HotShot

http://hotshot.docs.espressosys.com/
MIT License
119 stars 31 forks source link

Secure SRS for VID #1686

Closed ggutoski closed 5 months ago

ggutoski commented 1 year ago

Currently we use jellyfish's gen_srs_for_testing, even in production. Obviously, we shouldn't do that.

[EDIT: remove test-srs feature flag from Cargo.toml, too!]

In an ideal world this SRS would be loaded from a config file. Better yet, a default SRS could be hard-coded so as to save work on io/parse.

ggutoski commented 10 months ago

Perhaps the SRS should be in the sequencer. Hotshot should know nothing about that.

ggutoski commented 7 months ago

I don't know why this issue got closed. @jbearer we need this for decaf; is it also a priority for cappuccino sprint 2?

alxiong commented 7 months ago

we already have crs crate to load Aztec's SRS, right? what else do we want to achieve here? eval form for VID or?

ggutoski commented 7 months ago

Oh wow I wasn't even aware! We need to start using this in production. I'll leave this issue open until that's done.

alxiong commented 7 months ago

sure thing, here's the one-liner crs::aztec20::kzg10_setup(degree + 2) (the +2 is specific to our turboplonk design), feel free to mimic this.

https://github.com/search?q=repo%3AEspressoSystems%2Fespresso-sequencer+crs%3A%3Aaztec&type=code

(historical note: i added this when i tried to write proper non-mocked tests for light client contract, as we need to verify actual correct plonk proof on-chain, so used Aztec's SRS atm)

ggutoski commented 6 months ago

@akonring could help in my absence

ggutoski commented 5 months ago

Also need to remove test-srs feature flag from Cargo.toml too!