This is a second attempt at #3256, which was reverted. The tightening of the num_failed_views parameter in various tests is retained, but the check that we fail no fewer than num_failed_views was removed (since many tests do not reliably fail a specific number of views, this requires more work).
A consistency check was also added, to validate that each leaf chain from each node's decide events is coherent, and that no two nodes disagree on a leaf for any given view.
No linked issue.
This PR:
This is a second attempt at #3256, which was reverted. The tightening of the
num_failed_viewsparameter in various tests is retained, but the check that we fail no fewer thannum_failed_viewswas removed (since many tests do not reliably fail a specific number of views, this requires more work).A consistency check was also added, to validate that each leaf chain from each node's decide events is coherent, and that no two nodes disagree on a leaf for any given view.
This PR does not:
Key places to review: