EspressoSystems / HotShot

http://hotshot.docs.espressosys.com/
101 stars 25 forks source link

[DEPENDENCY_REFACTOR] - Fix the view number when canceling old dependency tasks #3342

Closed shenkeyao closed 2 weeks ago

shenkeyao commented 2 weeks ago

What is this task and why do we need to work on it?

[Pasted from Zulip.]

When canceling the old dependency task, we do: for view in (self.latest_voted_view + 1)..(new_view).

We previously fixed the range from [latest_voted_view + 1, new_view] to the current [latest_voted_view + 1, new_view), to not remove the latest in-progress dependency task. However, this means the current next_view, i.e., the future latest_voted_view, will never be removed.

What work will need to be done to complete this task?

A simple removal of + 1 should suffice.

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

Zulip discussion: https://espresso.zulipchat.com/#narrow/stream/311646-Consensus/topic/Dependency.20task.20refactor/near/445646768.

Branch work will be merged to (if not the default branch)

No response