search

EspressoSystems / HotShot

http://hotshot.docs.espressosys.com/
101 stars 25 forks source link

Remove combined fail increment #3387

Closed rob-maron closed 1 week ago

rob-maron commented 1 week ago

This removes a spot where we increment the primary network's failure counter when it's not clear if it failed or not. Right now if a view doesn't update for any reason within a specified amount of time, we treat this as a primary network failure. This would force nodes to use Libp2p if something else happens, like we are running into some timeouts

rob-maron commented 1 week ago

Are the test failures somehow related to this?

Unfortunately I don't think so, but it fixes an issue we saw in staging