Closed alxiong closed 1 year ago
Shall we consider remove Cargo.lock
? As this is a library crate, and we pinned to the commits.
I tried, but encountered some issue with espresso_systems_common::jellyfish::tag
.
There are binaries in this repo, such as gen-params.
Also I vaguely recall Nathan suggesting to commit lock file even for library for better reproducibility and avoid version conflict in dep that's hard to debug.
(I'm also open to any idea if there's good evidence)
There are binaries in this repo, such as gen-params.
Also I vaguely recall Nathan suggesting to commit lock file even for library for better reproducibility and avoid version conflict in dep that's hard to debug.
(I'm also open to any idea if there's good evidence)
Good point, the problem with espresso-systems-common
seems hard to fix.
https://github.com/EspressoSystems/cap/actions/runs/5488929132/jobs/10002431609 Any clue on why it's still not compiling in main? cc @alxiong @mrain @Ancient123
Feels weird to use ark_bls12_381::Bls12_377
. Is it a typo before?
96336e8822a9672c107a05e39cf7ec9fe897f2ea Seems this commit last year is not compiling either cc @alxiong
Possibly because of some arkworks changes?
error[E0412]: cannot find type `Bls12_377` in crate `ark_bls12_381`
Also we need to turn off -Zunstable-options --report-time
on the tests before it will run tests with current rust versions.
Ah sorry, this is an error that I missed! I'll fix that today!
Changes include:
bcd92b2
flake
, removed cargo-husky (since already using precommit hook in flake) and update README.