EspressoSystems / cap

Configurable Asset Privacy
GNU General Public License v3.0
33 stars 8 forks source link

ci: fix CI failure #137

Closed alxiong closed 1 year ago

alxiong commented 1 year ago

Changes include:

mrain commented 1 year ago

Shall we consider remove Cargo.lock? As this is a library crate, and we pinned to the commits.

I tried, but encountered some issue with espresso_systems_common::jellyfish::tag.

alxiong commented 1 year ago

There are binaries in this repo, such as gen-params.

Also I vaguely recall Nathan suggesting to commit lock file even for library for better reproducibility and avoid version conflict in dep that's hard to debug.

(I'm also open to any idea if there's good evidence)

mrain commented 1 year ago

There are binaries in this repo, such as gen-params.

Also I vaguely recall Nathan suggesting to commit lock file even for library for better reproducibility and avoid version conflict in dep that's hard to debug.

(I'm also open to any idea if there's good evidence)

Good point, the problem with espresso-systems-common seems hard to fix.

chancharles92 commented 1 year ago

https://github.com/EspressoSystems/cap/actions/runs/5488929132/jobs/10002431609 Any clue on why it's still not compiling in main? cc @alxiong @mrain @Ancient123

mrain commented 1 year ago

Feels weird to use ark_bls12_381::Bls12_377. Is it a typo before?

chancharles92 commented 1 year ago

96336e8822a9672c107a05e39cf7ec9fe897f2ea Seems this commit last year is not compiling either cc @alxiong

Possibly because of some arkworks changes?

Ancient123 commented 1 year ago

error[E0412]: cannot find type `Bls12_377` in crate `ark_bls12_381`

Ancient123 commented 1 year ago

Also we need to turn off -Zunstable-options --report-time on the tests before it will run tests with current rust versions.

alxiong commented 1 year ago

Ah sorry, this is an error that I missed! I'll fix that today!