Feat/t31 qc serde - Githubissues

EspressoSystems / hotshot-primitives

Primitives used in HotShot

https://hotshot-primitives.docs.espressosys.com/

3 stars 2 forks source link

Feat/t31 qc serde #39

Closed philippecamacho closed 1 year ago

philippecamacho commented 1 year ago

Closes #31. Some remarks:

The QC and the QC parameters can be (de)serialized.
Some minor changes to Jellyfish were required: see https://github.com/EspressoSystems/jellyfish/tree/fix/signature-scheme-serde
QCParams.stake_table_digest has been removed because (1) it is not used and (2) it creates complications for serde with Jellyfish (Schnorr signature).

chancharles92 commented 1 year ago

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

philippecamacho commented 1 year ago

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

You mean the stake table digest?

philippecamacho commented 1 year ago

LGTM, some minor comments. OTOH, do we also want to create a PR in Jellyfish for below? https://github.com/EspressoSystems/jellyfish/tree/fix/signature-scheme-serde

Yes, the PR has been created: https://github.com/EspressoSystems/jellyfish/pull/271

chancharles92 commented 1 year ago

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

You mean the stake table digest?

Yes

philippecamacho commented 1 year ago

@philippecamacho So later when we implement SNARK-based QC, we are going to put the hash_digest into Proof correct?

You mean the stake table digest?

Yes

Ok then yes, it make sense to have the stake table digest be a public input of the snark circuit.