Closed Ayiga closed 3 months ago
Closes #579
Removes the namespace_ids_for_offset method from the ExplorerHeader trait in favor of a namespace_id method on a new trait ExplorerTransaction.
namespace_ids_for_offset
ExplorerHeader
namespace_id
ExplorerTransaction
Add any consideration for representing the NamespaceId on the MockTransaction struct.
NamespaceId
MockTransaction
src/explorer/traits.rs This is where the new trait is defined, and the previous method is removed.
src/testing/mocks.rs This is where the traits are implemented for testing
Closes #579
This PR:
Removes the
namespace_ids_for_offsetmethod from theExplorerHeadertrait in favor of anamespace_idmethod on a new traitExplorerTransaction.This PR does not:
Add any consideration for representing the
NamespaceIdon theMockTransactionstruct.Key places to review:
src/explorer/traits.rs This is where the new trait is defined, and the previous method is removed.
src/testing/mocks.rs This is where the traits are implemented for testing