EspressoSystems / jellyfish

A Rust Implementation of the PLONK ZKP System and Extensions
https://jellyfish.docs.espressosys.com
MIT License
397 stars 100 forks source link

ci: update ci for unused dep #574

Closed alxiong closed 5 months ago

alxiong commented 5 months ago

This PR:

Fix CI failure for periodic check: https://github.com/EspressoSystems/jellyfish/actions/runs/8863541950/job/24337714873 (which always notify me on weekend 😢 )

How to test this PR:

since we didn't install cargo-udeps in nix shell, I was using my local exec, and I got:

└─○ cargo-udeps udeps --workspace --all-targets --features 'test-srs test-apis bls schnorr gadgets'                      
All deps seem to have been used.

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

mrain commented 5 months ago

Should we consider adding udeps in nix environment as well. Maybe not in this PR

alxiong commented 5 months ago

Yah we should. We could do it later.