HostOrDeviceSlice is now a trait. Occurrences are changed to concrete types now.
For Bn254 curve impl
commit_on_gpu now assume that the input scalars are in normal form instead of montgomery form.
now load_poly_to_gpu has one memory copy instead of free as before
these are because, icicle field impl now uses u32 limbs instead of u64 limbs as in arkworks.
add GPU stress test for memory leakage/fragmentation
This PR does not:
Key places to review:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[ ] Targeted PR against correct branch (main)
[ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added relevant changelog entries to the CHANGELOG.md of touched crates.
[ ] Re-reviewed Files changed in the GitHub PR explorer
no issue related.
This PR:
HostOrDeviceSlice
is now a trait. Occurrences are changed to concrete types now.Bn254
curve implcommit_on_gpu
now assume that the input scalars are in normal form instead of montgomery form.load_poly_to_gpu
has one memory copy instead of free as beforeu32
limbs instead ofu64
limbs as in arkworks.This PR does not:
Key places to review:
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
CHANGELOG.md
of touched crates.Files changed
in the GitHub PR explorer