EspressoSystems / jellyfish

A Rust Implementation of the PLONK ZKP System and Extensions
https://jellyfish.docs.espressosys.com
MIT License
408 stars 106 forks source link

chore: use tag for inter-dep among member crates #639

Closed alxiong closed 4 months ago

alxiong commented 4 months ago

This PR:

I encounter type compatibility error when trying to point to previously tagged jf-plonk-v0.5.0; where I realized that we are still using relative path path = "../xx" for inter-depenecy among member crates, which points to the head instead of a tagged version.

Since we made the decision in #556 to have independent version management/bumping among crates, we forgot to reflect that in our dependency declaration and this PR fixed that.

alxiong commented 4 months ago

I notice that when we tag 0.4.5 we forgot to bump the project root workspace.version: https://github.com/EspressoSystems/jellyfish/blob/0.4.5/Cargo.toml#L6

let's be more careful next time.