EspressoSystems / jellyfish

A Rust Implementation of the PLONK ZKP System and Extensions
https://jellyfish.docs.espressosys.com
MIT License
397 stars 100 forks source link

refactor!: refactored transcript traits and impls #648

Closed alxiong closed 2 months ago

alxiong commented 2 months ago

As observed in https://www.notion.so/espressosys/Fiat-Shamir-Transcript-f29ccc7a23c94178aac5cfa5d336fd63 and discussed on Zulip, we decide to remove get_and_append_challenge() and only use get_challenge() and also introduce back state for solidity transcript as most other projects do.

This partially undone some changes made in https://github.com/EspressoSystems/jellyfish/pull/619.

This PR:


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

alxiong commented 2 months ago

All of your comments are addressed in 2956aa5

I'll update the CHANGELOG when we merge all changes into main eventually.