revert!: deprecate VDF crate

mrain commented 3 weeks ago

closes: #649

This PR:

Deprecates the VDF crate because the original implemented MinRoot is insecure. Also we didn't and won't implement the verification part.

This PR does not:

Key places to review:

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[x] Targeted PR against correct branch (main)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[ ] Added relevant changelog entries to the CHANGELOG.md of touched crates.
[ ] Re-reviewed Files changed in the GitHub PR explorer

mrain commented 3 weeks ago

why are we keeping the minroot? afaik, no one, not even ourselves, is using it

No particular reason. Maybe we'll comeback to it sometime later (very not likely)

why sh3 hashchain? is it being used or planned anywhere?

I just picked a random hash function. Do you have other suggestions or would you prefer a somewhat generic implementation cc @ss-es

alxiong commented 3 weeks ago

i suggest we completely remove this. it's confusing already when we call it vdf without the verifiable property.

on the other hand, if we only need a delay function, do we really need to incorporate in jellyfish? a trivial hashchain implemented downstream to start with seems like a fine solution.

mrain commented 3 weeks ago

a trivial hashchain implemented downstream to start with seems like a fine solution.

That's a good idea. Since we don't have verification anyway and it's simple enough.

Shall we just completely remove this vdf crate?

alxiong commented 2 weeks ago

Shall we just completely remove this vdf crate?

I'd agree.

EspressoSystems / jellyfish