Remove derived implementations for private key types

EspressoSystems / jellyfish

A Rust Implementation of the PLONK ZKP System and Extensions

https://jellyfish.docs.espressosys.com

MIT License

408 stars 106 forks source link

Remove derived implementations for private key types #694

Closed mrain closed 3 weeks ago

mrain commented 1 month ago

Zulip discussion thread: https://espresso.zulipchat.com/#narrow/channel/311646-Consensus/topic/private.20keys/near/478545916

Summary: remove derived Serialize, Debug and Display for private key types. Implement Debug for them but only print *** or <private key> or something similar.

alxiong commented 4 weeks ago

we should also add from/to_bytes() on private keys.