jf-vrf crate should be updated after to adopt these changes in jf-signature.
Key places to review:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x] Targeted PR against correct branch (main)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[x] Updated relevant documentation in the code
[x] Added relevant changelog entries to the CHANGELOG.md of touched crates.
[ ] Re-reviewed Files changed in the GitHub PR explorer
closes: #694
This PR:
In
jf-signature
crateDebug
for private signing keys to not print the actual value.to/from_bytes()
and the conversions to/fromTaggedBase64
.This PR does not:
Private key type in
elgamal
crate still has derivations. Because of this ephemeral key in the ciphertext: https://github.com/EspressoSystems/jellyfish/blob/5f06aa175e8d49100203b027c08aa8d174e3f0d4/elgamal/src/lib.rs#L147Private key type in
aead
crate still has derivations. Because of this ephemeral key in the ciphertext: https://github.com/EspressoSystems/jellyfish/blob/5f06aa175e8d49100203b027c08aa8d174e3f0d4/aead/src/lib.rs#L279jf-vrf
crate should be updated after to adopt these changes injf-signature
.Key places to review:
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
CHANGELOG.md
of touched crates.Files changed
in the GitHub PR explorer