search

EspressoSystems / nitro-espresso-integration

Nitro goes vroom and fixes everything
Other
12 stars 7 forks source link

Remove espresso sequencer #214

Closed Sneh1999 closed 2 months ago

Sneh1999 commented 2 months ago

Closes #213

https://github.com/EspressoSystems/nitro-espresso-integration/issues/213

This PR:

Removes any redundant code related to Espresso sequencer

This PR does not:

Key places to review:

Sneh1999 commented 2 months ago

https://github.com/EspressoSystems/nitro-espresso-integration/blob/ae846333e93c6c097262be6579f005d65a986444/arbos/block_processor.go#L99-L104

I think we can also remove these code

Done! (bfae26b)

ImJeremyHe commented 2 months ago

It looks like you didn't update the submodule. Can you try git submodule update --remote go-ethereum and commit the submodule update?

Sneh1999 commented 2 months ago

Done! Thanks 35ad823

Sneh1999 commented 2 months ago

It looks like you didn't update the submodule. Can you try git submodule update --remote go-ethereum and commit the submodule update?

@ImJeremyHe I have reverted the changes to use go-ethereum as I realized later that the master branch of go-ethereum contains some breaking changes which dont work with our current code and as a reason the build was failing. I will create a separate PR to migrate to go-ethereum but would leave these changes out from this PR as it will make this PR pretty big.

sveitser commented 2 months ago

Edit: Nevermind the comment below, you linked their fork of geth already. But if we use their fork of geth we should use the commit that is used in upstream nitro at the last commit that we synced this fork with, not their master branch.

@Sneh1999 Arbitrum uses their own fork of geth https://github.com/OffchainLabs/go-ethereum, so if we remove our fork we should use theirs, not upstream go-ethereum.