search

EspressoSystems / nitro-espresso-integration

Nitro goes vroom and fixes everything
Other
12 stars 7 forks source link

Remove hardcoded namespace.rs library #87

Open nomaxg opened 7 months ago

nomaxg commented 7 months ago

Making espresso-sequencer wasm compatible would have been quite a lot of effort, and the sequencer repo wasn't compiling nicely in the test-node environment. For now, I did the very hacky thing of copying all VID verification code to its own standalone module. Long term we will need a better solution, I don't think that the sequencer repo is in a great state currently as an external dependency because of how coupled everything is. We should probably have all of the "pure" data structures in its own repo/module, ensuring that it can compile to wasm.

Update 2024-08-19:

There is currenly code in the nitro integration that is copied from Espresso sequencer because it wasn't possible to compile espresso-sequencer in the nitro environment. We have since then created a types crate in espresso sequencer that may or may not help with this. This issue can be closed if we have a way to no-longer include copied code from elsewhere into the nitro integration repo. We may have to create a separate crate that includes the espresso crypto that we can then use in the sequencer and in the nitro integration.

sveitser commented 2 months ago

We can try to compile the types crate in the espresso-sequencer again.

sveitser commented 4 weeks ago

We probably don't need this anymore if we move towards upfront validation of batches in L1.