search

Esqarrouth / EZLoadingActivity

:hatching_chick: Lightweight Swift loading activity for iOS7+
MIT License
608 stars 82 forks source link

-- Add an option to show the loading activity to application window #17

Closed mustafaibrahim989 closed 7 years ago

mustafaibrahim989 commented 8 years ago

-- Add an option to show the loading activity to application window -- Xcode 7.3.1 support

Esqarrouth commented 8 years ago

Hey, whats the purpose of this feature?

mustafaibrahim989 commented 8 years ago

Sometimes you want to add the loading activity over the application window to be at the top most layer. for example if you present a modal VC and you need to show the loading from the presenting VC.

rugheid commented 8 years ago

Can this pull request be resolved, because this would also fix the loading indicator for split view controllers. Now it's hidden:

img_0626

I would only change line 155: UIApplication.sharedApplication().windows.first?.addSubview(self) to UIApplication.sharedApplication().keyWindow?.addSubview(self). I also don't see why you wouldn't just always use the window, because that always works.

Esqarrouth commented 8 years ago

There are merge conflicts, can you resolve it and resubmit this?

mustafaibrahim989 commented 8 years ago

@goktugyil I've fixed the conflicts. You can merge now 👍

lfarah commented 7 years ago

Hey @mustafaibrahim989, I'm so sorry.... Been working a lot on Swit 3 migrations and I just found this PR.... Would you be able to fix the conflicts once I port the Swift 3 of this library?

mustafaibrahim989 commented 7 years ago

@lfarah I've fixed the conflicts. You can merge 👍

Esqarrouth commented 7 years ago

Thanks 👍

Esqarrouth commented 7 years ago

Would you mind adding this to readme?

mustafaibrahim989 commented 7 years ago

Sure