search

Esqarrouth / EZLoadingActivity

:hatching_chick: Lightweight Swift loading activity for iOS7+
MIT License
608 stars 82 forks source link

View is pretty large on Ipad #7

Closed NickBols closed 8 years ago

NickBols commented 8 years ago

Hey

I love your implementation of this and how simple it is to use! Tried it for Ipad but it covered almost the entire screen which is a bit brute :D So I added this setting which let's you manually set the width divider (standard was 1.6)

Probably not the prettiest way to add to it but it works and it's a very fast enhancement :)

In Settings struct static var CLAWidthDivision = 1.6 In loadingActivity: let width = sender.view.frame.width / CGFloat(Settings.CLAWidthDivision) Before calling showMethod: CozyLoadingActivity.Settings.CLAWidthDivision = 4.6 (about right for Ipad)

Thanks again!

PS don't use github that much so thought I'd add it here and you can mark it as enhancement or something :) Cheers

Esqarrouth commented 8 years ago

Hello, can you take a screen shot before and after you made this difference? I might add this as a feature that automatically works in ipads if needed. Just need to see your screen. Thanks for using and reporting this issue

azeemOshaan commented 8 years ago

after before

Tested on iPad 2/ iOS 9.1 simulator

Esqarrouth commented 8 years ago

I'll create an update soon

Esqarrouth commented 8 years ago

https://github.com/goktugyil/CozyLoadingActivity/commit/517b8240039587cf9af7d70a1fe5fc9e5471a62a https://github.com/goktugyil/CozyLoadingActivity/commit/fa2cdf23a91fc0dae407c596c62ee65033c84b6d

fixed. thanks for reporting