search

Esqarrouth / EZLoadingActivity

:hatching_chick: Lightweight Swift loading activity for iOS7+
MIT License
607 stars 82 forks source link

Orientation issue #9

Closed polis80cy closed 8 years ago

polis80cy commented 8 years ago

Thanks for the lovely simple-to-use control.

I noticed however that it doesn't support landscape orientation. It keeps showing the animation based on the initial portrait orientation.

Esqarrouth commented 8 years ago

Hello, thanks.

You can write a landscape orientation version and send a pull request if you like. Otherwise I might be able to add that feature this weekend.

craigpearce5 commented 8 years ago

Has this been tested? It doesn't seem to work for me.

Esqarrouth commented 8 years ago

If you are using the pod version, I didn't update it yet. I'll update it now

Esqarrouth commented 8 years ago

it should work now

craigpearce5 commented 8 years ago

I've updated the code and it still places the loadingActivity in the bottom left corner of the screen.

Esqarrouth commented 8 years ago

Can you show a screen shot? maybe its a use case we haven't thought about

craigpearce5 commented 8 years ago

simulator screen shot jan 10 2016 12 14 18 pm

craigpearce5 commented 8 years ago

The above photo is a simulator screenshot. Kind of bad quality as I had to set slow animations and even then it appeared and disappeared quite quickly.

craigpearce5 commented 8 years ago

Hmmm... I just copied and pasted the code from the main github repo page and it works now. Previously I had been using the code from the .zip file in the latest release page. Are they different?

Esqarrouth commented 8 years ago

The files look the same and are supposed to be same too. You may have downloaded the version before this maybe? I checked it and v0.7 seems to be fine.

Let me know if you see issues in the future

craigpearce5 commented 8 years ago

Thanks for looking into that. Sorry for the confusion.