New Danger tests - Githubissues

Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.

MIT License

3k stars 381 forks source link

New Danger tests #242

Open lfarah opened 8 years ago

lfarah commented 8 years ago

so now we need to find a way to

Ensure documentation in the method by checking for ///
Ensure that each new PR of a new extension has a Test.

I have an idea on how to easily do number 2: We need to have a Pull Request Template and if the user checked [X] for New extension, we ensure tests

piv199 commented 8 years ago

My drafts

On added file count or check modifying pbproject file
Big PR, total lines out of 150-200 or more?
If sources modyfied and changed symbols more than x, change changelog, or check PR if its #trivial
swiftlint errors
Work in progress PR
forbid changing some files or include some text in PR if not a collaborator
if PR is not mergable, warn, but it may be obvious by github

lfarah commented 8 years ago

Danger Xcode Summary Plugin - A Danger plugin that shows all build errors, warnings and unit tests results generated from xcodebuild.

piv199 commented 8 years ago

On weekend will add support for trivial change and related changes