Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.
MIT License
3k stars 381 forks source link

Match httpDateString with ISO8601 formats #426

Closed kusakusakusa closed 7 years ago

kusakusakusa commented 7 years ago

Checklist

Default timestamp from http json responses for Ruby on Rails follows ISO8601 format.

EZSwiftExtensionsBot commented 7 years ago
2 Messages
:book: Executed 193 tests, with 0 failures (0 unexpected) in 5.549 (5.752) seconds
:book: Executed 178 tests, with 0 failures (0 unexpected) in 5.938 (6.122) seconds

Generated by :no_entry_sign: Danger

codecov-io commented 7 years ago

Codecov Report

Merging #426 into master will increase coverage by 0.93%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   40.44%   41.38%   +0.93%     
==========================================
  Files          49       50       +1     
  Lines        2193     2216      +23     
==========================================
+ Hits          887      917      +30     
+ Misses       1306     1299       -7
Impacted Files Coverage Δ
Sources/DateExtensions.swift 96.18% <100%> (+0.38%) :arrow_up:
Sources/FileManagerExtension.swift 100% <0%> (ø)
Sources/UIViewExtensions.swift 7.27% <0%> (+3.74%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a5e225...15615f1. Read the comment docs.

Khalian commented 7 years ago

Moreover, these changes also need changelog entries.