Macos support for EZSwiftExtensions.

Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.

MIT License

3k stars 381 forks source link

Macos support for EZSwiftExtensions. #433

Closed Khalian closed 7 years ago

Khalian commented 7 years ago

Checklist

[ ] New Extension
[ ] New Test
[x] Changed more than one extension, but all changes are related
[x] Trivial change (doesn't require changelog)

Khalian commented 7 years ago

@goktugyil - I want to put this change in before I draft the new release. I would appreciate your review for this one, since this is a massive change.

EZSwiftExtensionsBot commented 7 years ago

	2 Errors
:no_entry_sign:	Please, modify only one extension per pull request.
:no_entry_sign:	Please, modify only one extension per pull request.

	3 Messages
:book:	Executed 198 tests, with 0 failures (0 unexpected) in 5.978 (6.352) seconds
:book:	Executed 183 tests, with 0 failures (0 unexpected) in 5.254 (5.408) seconds
:book:	Executed 120 tests, with 0 failures (0 unexpected) in 4.367 (4.456) seconds

Generated by :no_entry_sign: Danger

Esqarrouth commented 7 years ago

Code looks good, but I'm worried about the proj and scheme files. Usually you can't catch issues in those without stumbling into it while using :/

Esqarrouth commented 7 years ago

Lets just not make a version for a while, gives us time to catch stuff.

Esqarrouth commented 7 years ago

Also why not use #if !os(macOS) ?

Khalian commented 7 years ago

@goktugyil I agree. I can guarantee you the following.

The build works fine.
The target builds fine locally on my XCode.
The tests run fine locally on my XCode.

How about I keep these changes for a couple of weeks or so? After that I can draft a release.

Regardng !os(macOS), I also have to make changes for linux and maybe watchOS depending on demand. In linux, UI Kit is not defined, so this change is good.