Minor crash resolved - Githubissues

Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.

MIT License

3k stars 381 forks source link

Minor crash resolved #473

Open ioskunal opened 6 years ago

ioskunal commented 6 years ago

invalid check mistake resolved

Checklist

[ ] New Extension
[ ] New Test
[ ] Changed more than one extension, but all changes are related
[ ] Trivial change (doesn't require changelog)

Esqarrouth commented 6 years ago

Thanks for the PR. Is there an associated test with this? Did it run before? Does it run now?

ioskunal commented 6 years ago

Thanks for quick reply. I tested this manually. The loop has to be executed from 0 to n-1 where as it runs from 0 to n and then it crashes at n index. I had checked this and now it works fine.

EZSwiftExtensionsBot commented 6 years ago

	1 Error
:no_entry_sign:	Making non-trivial change requires changelog entry! Please, set trivial change or add entry to changelog.

	2 Messages
:book:	Executed 203 tests, with 0 failures (0 unexpected) in 6.527 (6.789) seconds
:book:	Executed 125 tests, with 0 failures (0 unexpected) in 4.777 (4.869) seconds

Generated by :no_entry_sign: Danger

Esqarrouth commented 6 years ago

Could you edit the test cases here so it gives an asset while running the code:

for i in 0...length {

But doesn't give an assert with:

for i in 0..<length {

https://github.com/goktugyil/EZSwiftExtensions/blob/master/EZSwiftExtensionsTests/StringTests.swift