Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.
MIT License
3k stars 381 forks source link

Final merge for swift 4 #476

Closed Khalian closed 6 years ago

Khalian commented 6 years ago

Checklist

Khalian commented 6 years ago

Rebased off of top of master. @lfarah @goktugyil

EZSwiftExtensionsBot commented 6 years ago
1 Error
:no_entry_sign: Please, modify only one extension per pull request.
3 Messages
:book: Executed 202 tests, with 0 failures (0 unexpected) in 5.618 (6.233) seconds
:book: Executed 187 tests, with 0 failures (0 unexpected) in 4.361 (4.559) seconds
:book: Executed 124 tests, with 0 failures (0 unexpected) in 4.132 (4.250) seconds

Generated by :no_entry_sign: Danger

isimple4 commented 6 years ago

Finally!

Khalian commented 6 years ago

@isimple4 You authored part of it, so you can also approve this. Ignore the danger build, since its irrelevant for this PR.

isimple4 commented 6 years ago

@Khalian Cool! I'll do that. Thanks for the info.

Khalian commented 6 years ago

@goktugyil I think this should be good to go now ?