Open shanyanhai opened 6 years ago
5 Errors | |
---|---|
:no_entry_sign: | Please, modify only one extension per pull request. |
:no_entry_sign: | Sources/EZSwiftFunctions.swift#L81: unexpected platform condition (expected ‘os’, ‘arch’, or ‘swift’)
#if targetEnvironment(simulator)
|
:no_entry_sign: | Sources/EZSwiftFunctions.swift#L90: unexpected platform condition (expected ‘os’, ‘arch’, or ‘swift’)
#if targetEnvironment(simulator)
|
:no_entry_sign: | Sources/ArrayExtensions.swift#L26: cannot convert value of type ‘CountableRange<Array.Index>’ (aka ‘CountableRange<Int>’) to expected argument type ‘Range<Int>’
let halfOpenClampedRange = Range(range).clamped(to: indices)
|
:no_entry_sign: | Sources/ArrayExtensions.swift#L117: value of type ‘EnumeratedSequence<[Element]>’ has no member ‘compactMap’
return enumerated().compactMap { ($0.element == element) ? $0.offset : nil }
|
Generated by :no_entry_sign: Danger
Please use the Xcode Version 10.0, supporter Swift 4.2. No major logical changes,Swift4.2:Many enums class names have been changed, if modify only one extension per pull request.Time consuming.
@shanyanhai
Hi there, Is there any way to pod your updated branch to my project?
@shanyanhai Hi there, Is there any way to pod your updated branch to my project? pod 'EZSwiftExtensions', :git => 'https://github.com/shanyanhai/EZSwiftExtensions.git', :branch => 'Swift4.2'
@shanyanhai You should update travis configuration to specify Xcode version. And maybe Xcode 10 GM is a better choice rather than a beta version.
@shanyanhai Thanks very much. You did me a big favor.
@shanyanhai Thanks very much. You did me a big favor.
Xcode (10A254a) ---OK , I'm using. I don't know how to update Travis configuration /:wipe
Cross check the official effort here : https://github.com/goktugyil/EZSwiftExtensions/pull/496. I think I covered all your changes here and made further progress on this.
in code: Fix Any warning Fix emoji judge Known issues : traverse enum is failure in Test : String does not belong to NSObject and does not have the classname attribute.(location: testClassName)
testClassName
Checklist