Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.
MIT License
3k stars 381 forks source link

Date formatter performance #493

Closed rahimkhalid closed 5 years ago

rahimkhalid commented 5 years ago

Checklist

EZSwiftExtensionsBot commented 5 years ago
3 Messages
:book: Executed 205 tests, with 0 failures (0 unexpected) in 5.091 (5.319) seconds
:book: Executed 190 tests, with 0 failures (0 unexpected) in 4.290 (4.469) seconds
:book: Executed 127 tests, with 0 failures (0 unexpected) in 3.814 (3.883) seconds

Generated by :no_entry_sign: Danger

codecov-io commented 5 years ago

Codecov Report

Merging #493 into master will increase coverage by 0.76%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage    43.6%   44.37%   +0.76%     
==========================================
  Files          52       53       +1     
  Lines        2314     2346      +32     
==========================================
+ Hits         1009     1041      +32     
  Misses       1305     1305
Impacted Files Coverage Δ
Sources/SynchronizedDictionary.swift 100% <100%> (ø)
Sources/DateExtensions.swift 97.14% <100%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e9e81e...f1be0e5. Read the comment docs.

rahimkhalid commented 5 years ago

@Khalian @goktugyil can you kindly add reviewers for this PR.

rahimkhalid commented 5 years ago

@Khalian I think this pull request is now ready to be merged.