search

Esqarrouth / EZSwiftExtensions

:smirk: How Swift standard types and classes were supposed to work.
MIT License
3k stars 381 forks source link

Ceeyang swift5.0 (Build fixes). #501

Open Khalian opened 5 years ago

Khalian commented 5 years ago

Checklist

Khalian commented 5 years ago

Related to https://github.com/goktugyil/EZSwiftExtensions/pull/499, with fixes on the build.

EZSwiftExtensionsBot commented 5 years ago
23 Errors
:no_entry_sign: Please, modify only one extension per pull request.
:no_entry_sign: EZSwiftExtensionsTests/BoolTests.swift#L22: ambiguous use of ‘toggle()’
value.toggle()
:no_entry_sign: EZSwiftExtensionsTests/NSAttributedStringTests.swift#L33: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
XCTAssertEqual(newAttributesSeen[NSAttributedStringKey.font] as! UIFont, UIFont.boldSystemFont(ofSize: UIFont.systemFontSize))
:no_entry_sign: EZSwiftExtensionsTests/NSAttributedStringTests.swift#L44: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
XCTAssertEqual(newAttributesSeen[NSAttributedStringKey.underlineStyle] as! Int, NSUnderlineStyle.styleSingle.rawValue)
:no_entry_sign: EZSwiftExtensionsTests/NSAttributedStringTests.swift#L55: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
XCTAssertEqual(newAttributesSeen[NSAttributedStringKey.font] as! UIFont, UIFont.italicSystemFont(ofSize: UIFont.systemFontSize))
:no_entry_sign: EZSwiftExtensionsTests/NSAttributedStringTests.swift#L62: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
XCTAssertEqual(newAttributesSeen[NSAttributedStringKey.strikethroughStyle] as! NSNumber, NSNumber(value: NSUnderlineStyle.styleSingle.rawValue as Int))
:no_entry_sign: EZSwiftExtensionsTests/NSAttributedStringTests.swift#L74: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
XCTAssertEqual(newAttributesSeen[NSAttributedStringKey.foregroundColor] as! UIColor, grayColor)
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L376: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let boldResult = NSAttributedString(string: testString, attributes: [NSAttributedStringKey.font: UIFont.boldSystemFont(ofSize: UIFont.systemFontSize)])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L377: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let boldResult2 = NSAttributedString(string: testString2, attributes: [NSAttributedStringKey.font: UIFont.boldSystemFont(ofSize: UIFont.systemFontSize)])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L378: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let underlineResult = NSAttributedString(string: testString, attributes: [NSAttributedStringKey.underlineStyle: NSUnderlineStyle.styleSingle.rawValue])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L379: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let underlineResult2 = NSAttributedString(string: testString2, attributes: [NSAttributedStringKey.underlineStyle: NSUnderlineStyle.styleSingle.rawValue])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L381: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let italicResult = NSAttributedString(string: testString, attributes: [NSAttributedStringKey.font: UIFont.italicSystemFont(ofSize: UIFont.systemFontSize)])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L382: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let italicResult2 = NSAttributedString(string: testString2, attributes: [NSAttributedStringKey.font: UIFont.italicSystemFont(ofSize: UIFont.systemFontSize)])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L384: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let colorResult = NSAttributedString(string: testString, attributes: [NSAttributedStringKey.foregroundColor: UIColor.green])
:no_entry_sign: EZSwiftExtensionsTests/StringTests.swift#L385: ‘NSAttributedStringKey’ has been renamed to ‘NSAttributedString.Key’
let colorResult2 = NSAttributedString(string: testString2, attributes: [NSAttributedStringKey.foregroundColor: UIColor.green])
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L204: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedToday: TimePassed = today.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L208: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedFifteenYearsAgo: TimePassed = fifteenYearsAgo!.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L212: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedTwoMonthsAgo: TimePassed = twoMonthsAgo!.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L216: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedYesterday: TimePassed = yesterday!.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L220: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedSixHoursAgo: TimePassed = sixHoursAgo!.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L224: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedThirteenMinutesAgo: TimePassed = thirteenMinutesAgo!.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L228: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedFiveSecondsAgo: TimePassed = fiveSecondsAgo!.timePassed()
:no_entry_sign: EZSwiftExtensionsTests/DateTests.swift#L232: cannot convert value of type ‘String’ to specified type ‘TimePassed’
let timePassedOneSecondAgo: TimePassed = oneSecondAgo!.timePassed()
57 Warnings
:warning: Sources/DoubleExtensions.swift#L40: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "rounded(toPlaces:)")
:warning: Sources/DoubleExtensions.swift#L46: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "round(toPlaces:)")
:warning: Sources/DoubleExtensions.swift#L52: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "ceiled(toPlaces:)")
:warning: Sources/DoubleExtensions.swift#L58: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "ceil(toPlaces:)")
:warning: Sources/ArrayExtensions.swift#L233: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "containsType(of:)")
:warning: Sources/ArrayExtensions.swift#L239: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "get(at:)")
:warning: Sources/ArrayExtensions.swift#L245: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "testAll(is:)")
:warning: Sources/ArrayExtensions.swift#L255: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "removeFirst(_:)")
:warning: Sources/ArrayExtensions.swift#L266: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "insertFirst(_:)")
:warning: Sources/ArrayExtensions.swift#L276: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "contains(_:)")
:warning: Sources/ArrayExtensions.swift#L282: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "indexes(of:)")
:warning: Sources/ArrayExtensions.swift#L288: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "lastIndex(_:)")
:warning: Sources/ArrayExtensions.swift#L294: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "removeFirstObject(_:)")
:warning: Sources/ArrayExtensions.swift#L307: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.6, renamed: "flatMap(_:)")
:warning: Sources/ArrayExtensions.swift#L313: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.6, renamed: "forEachEnumerated(_:)")
:warning: Sources/CGFloatExtensions.swift#L18: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "degreesToRadians")
:warning: Sources/NSDictionaryExtensions.swift#L17: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8)
:warning: Sources/NSDictionaryExtensions.swift#L28: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8)
:warning: Sources/UIFontExtensions.swift#L99: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8)
:warning: Sources/UIImageViewExtensions.swift#L106: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "image(url:)")
:warning: Sources/UIImageViewExtensions.swift#L118: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "image(url:placeholder:)")
:warning: Sources/UIImageViewExtensions.swift#L125: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8, renamed: "image(url:placeholderNamed:)")
:warning: Sources/BundleExtensions.swift#L18: ‘public’ modifier is redundant for class method declared in a public extension
public class func loadNib(_ name: String, owner: AnyObject!) {
:warning: Sources/BundleExtensions.swift#L24: ‘public’ modifier is redundant for class method declared in a public extension
public class func loadNib<T>(_ name: String) -> T? {
:warning: Sources/ArrayExtensions.swift#L107: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
return array.testAll { self.index(of: $0) ?? -1 >= 0 }
:warning: Sources/ArrayExtensions.swift#L112: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
return elements.testAll { self.index(of: $0) ?? -1 >= 0 }
:warning: Sources/ArrayExtensions.swift#L117: ‘flatMap’ is deprecated: Please use compactMap(_:) for the case where closure returns an optional value
return enumerated().flatMap { ($0.element == element) ? $0.offset : nil }
:warning: Sources/ArrayExtensions.swift#L127: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
guard let index = index(of: element) else { return }
:warning: Sources/ArrayExtensions.swift#L309: ‘flatMap’ is deprecated: Please use compactMap(_:) for the case where closure returns an optional value
return flatMap { map($0) }
:warning: Sources/FloatingPointExtensions.swift#L41: ‘4294967295’ is not exactly representable as ‘Float’; it becomes ‘4294967296’
return Float(arc4random()) / 0xFFFFFFFF
:warning: Sources/CGFloatExtensions.swift#L55: ‘4294967295’ is not exactly representable as ‘Float’; it becomes ‘4294967296’
return CGFloat(Float(arc4random()) / 0xFFFFFFFF)
:warning: Sources/StringExtensions.swift#L196: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.6, renamed: "isBlank")
:warning: Sources/UIColoredView.swift#L13: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8)
:warning: Sources/EZSwiftFunctions.swift#L81: platform condition appears to be testing for simulator environment; use ‘targetEnvironment(simulator)’ instead
#if (arch(i386) || arch(x86_64)) && os(iOS)
:warning: Sources/EZSwiftFunctions.swift#L90: platform condition appears to be testing for simulator environment; use ‘targetEnvironment(simulator)’ instead
#if (arch(i386) || arch(x86_64)) && os(iOS)
:warning: Sources/EZSwiftFunctions.swift#L268: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "DispatchQueue.main")
:warning: Sources/EZSwiftFunctions.swift#L274: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "DispatchQueue.main")
:warning: Sources/EZSwiftFunctions.swift#L281: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "DispatchQueue.global()")
:warning: Sources/EZSwiftFunctions.swift#L287: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "DispatchQueue.global()")
:warning: Sources/EZSwiftFunctions.swift#L293: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "DispatchQueue.global()")
:warning: Sources/EZSwiftFunctions.swift#L299: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.7, renamed: "DispatchQueue.global()")
:warning: Sources/UIViewControllerExtensions.swift#L283: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.9)
:warning: Sources/NSDictionaryExtensions.swift#L18: ‘public’ modifier is redundant for initializer declared in a public extension
public convenience init ? (json: String) {
:warning: Sources/NSDictionaryExtensions.swift#L29: ‘public’ modifier is redundant for instance method declared in a public extension
public func formatJSON() -> String? {
:warning: Sources/IntExtensions.swift#L53: will never be executed
return -1; //out of bound
:warning: EZSwiftExtensions/UIStackViewExtensions.swift#L27: Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they’re in multiple lines in a declaration. (vertical_parameter_alignment)
Linting 'CGRectExtensions.swift' (4/57)
:warning: EZSwiftExtensionsTests/NSDictionaryTests.swift#L14: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8)
:warning: EZSwiftExtensionsTests/NSDictionaryTests.swift#L22: unexpected version number in ‘available’ attribute for non-specific platform ‘*’
@available(*, deprecated: 1.8)
:warning: EZSwiftExtensionsTests/DictionaryTests.swift#L65: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
XCTAssertNotNil(array.index(of: "TWO2"))
:warning: EZSwiftExtensionsTests/DictionaryTests.swift#L66: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
XCTAssertNotNil(array.index(of: "FIVE5"))
:warning: EZSwiftExtensionsTests/ArrayTests.swift#L274: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
if let i = shuffledArray.index(of: e) {
:warning: EZSwiftExtensionsTests/ArrayTests.swift#L283: ‘index(of:)’ is deprecated: renamed to ‘firstIndex(of:)’
if let i = numberArray2.index(of: e) {
:warning: /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L247: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
@interface BlockWebView : UIWebView <UIWebViewDelegate>
:warning: /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L250: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (void)webViewDidStartLoad:(UIWebView * _Nonnull)webView;
    ```
    • <
:warning: /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L251: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (void)webViewDidFinishLoad:(UIWebView * _Nonnull)webView;
    ```
    • <
:warning: /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L252: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (void)webView:(UIWebView * _Nonnull)webView didFailLoadWithError:(NSError * _Nonnull)error;
    ```
    • <
:warning: /Users/travis/Library/Developer/Xcode/DerivedData/EZSwiftExtensions-cknupuhyerhvhtfuqvigkfkoxukr/Build/Products/Debug-iphonesimulator/EZSwiftExtensions.framework/Headers/EZSwiftExtensions-Swift.h#L253: ‘UIWebView’ is deprecated: first deprecated in iOS 12.0 - No longer supported; please adopt WKWebView.
```

  • (BOOL)webView:(UIWebView * _Nonnull)webView shouldStartLoadWithRequest:(NSURLRequest * _Nonnull)request navigationType:(enum UIWebViewNavigationType)navigationType SWIFT_WARN_UNUSED_RESULT;
    ```
    • <

Generated by :no_entry_sign: Danger

ceeyang commented 5 years ago

I will make a new Pull Request

ceeyang commented 5 years ago

pod 'EZSwiftExtensions', :git => 'https://github.com/ceeyang/EZSwiftExtensions.git', :branch => 'Swift5.0'