EsreverWoW / ClassicThreatMeter

A simple threat meter for WoW Classic (1.13.2)
37 stars 7 forks source link

[BUG] Intimidation not being tracked #16

Open alan-smith-vt opened 5 years ago

alan-smith-vt commented 5 years ago

What steps will reproduce the problem?

  1. Should be obvious, but here's what I did. I built up around 400 damage on a mob, then hit intimidation and sent pet in. Pet does two auto attacks for a total of 98 damage as well as procing intimidation. Mob swaps aggro to pet. Threat meter shows player at 400 threat (or whatever the damage was done) and shows pet at 98 threat.

What version of ClassicThreatMeter are you using? (Stating 'latest' is not useful)

1.06

Do you have an error log of what happened?

Not applicable I don't think. I could link the combatlog but that would be unhelpful.

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

I believe the issue to be that intimidation is an applied debuff, not a cast. Where intimidation is in the code suggests it is treated like a spell cast such as growl.

Looking at the combat log it goes: 1) Spell-cast-success intimidation player -> pet 2) Spell-aura-applied intimidation player -> pet (buff) 3) Spell-aura-removed intimidation player-pet (buff) 4) Spell-aura-applied intimidation pet -> target (debuff)

The fourth part is what should be tracked to apply the threat increase. Blizzard has some blocks preventing debuff tracking so there may be an issue with that.