Druid Threat Being Calculated incorrectly

[blitzcrg]

My guild's other tank and I have noticed issues where I'll routinely pull aggro as a feral druid tank even when well behind our prot warrior main tank on the meter. I suspect the issue is in https://github.com/EsreverWoW/LibThreatClassic/blob/master/ClassModules/Classic/Druid.lua:

function Druid:ScanTalents()
    if ThreatLib.Classic then
        self.feralinstinctMod = 0.03 * select(5, GetTalentInfo(2, 3))
        self.subtletyMod = 1 - 0.04 * select(5, GetTalentInfo(3, 8))
        self.tranqMod = 1 - 0.5 * select(5, GetTalentInfo(3, 13))
    else
        self.feralinstinctMod = 0 -- for when testing in retail
        self.subtletyMod = 1 -- for when testing in retail
        self.tranqMod = 1 -- for when testing in retail
    end
end

I believe Feral Instincts modifier is multiplicative, not additive; self.feralinstinctMod should be calculated as 1 + 0.03 * select(5, GetTalentInfo(2, 3)), and then used differently in

function Druid:GetStanceThreatMod()
    local form = GetShapeshiftForm()
    self.isTanking = false
    if form == 1 then
        self.passiveThreatModifiers = 1.3 + self.feralinstinctMod
        self.isTanking = true
    elseif form == 2 then
        self.passiveThreatModifiers = 0.71
    else
        self.passiveThreatModifiers = 1
    end
    self.totalThreatMods = nil -- Needed to recalc total mods
end

by multiplication, ie self.passiveThreatModifiers = 1.3 * self.feralinstinctMod

Additionally, Swipe threat doesn't appear to take into account the passive bear form modifier or the feral instinct modifier, both of which should apply. Of course this might be applied elsewhere in the code.

function Druid:Swipe(amount)
    return amount * 1.75
end

[cannonpalms]

No threat modifiers are additive after patch 1.12:

Threat Reduction Effects: This system has been redesigned to eliminate inconsistency in how the effects work. Previously, some were additive (for example: 30% reduction + 20% reduction = 50% reduction) while others were multiplicative (30% reduction and 20% reduction made 44% reduction, from 0.7*0.8). They are now all multiplicative. This also prevents unpredictable behavior when the total reduction percentage was equal to or greater than 100%. Please note that in almost all cases, when stacking multiple threat reduction effects you will experience less threat reduction than previously.

However, regarding swipe, you are misunderstanding the code. Have a look at the way AbilityHandler functions are used in the core class module. The current implementation of swipe is correct.

[cannonpalms]

To-do:

• [ ] Correct feral instinct modifier to calculate multiplicatively
• [ ] Check for additional instances of modifiers being handled additively

[cannonpalms]

Issue migrated to cannonpalms/LibThreatClassic#14

[dfherr]

this issue is fixed in https://github.com/dfherr/LibThreatClassic2