PFStein
commented
4 years ago Closing. Fixed in: https://github.com/dfherr/LibThreatClassic2/pull/3
Closed PFStein closed 4 years ago
PFStein
commented
4 years ago Closing. Fixed in: https://github.com/dfherr/LibThreatClassic2/pull/3
What's this do?
Clears threat of the primary target of an onyxia fireball.
Why are we doing this?
On november 8th Blizzard implemented a hotfix to clear threat on the primary target of a fireball. This should correctly reflect the functionality of that hotfix. https://www.wowhead.com/news=296156/wow-classic-november-8th-hotfixes-pvp-guard-behavior-onyxia-fireball-threat
Anything the reviewer(s) should know to review effectively?
Fireball spell ID per WoWhead classic -> https://classic.wowhead.com/spell=18392/fireball#see-also-other
Any questions for the reviewers?
I looked through the overall structure of the codebase and this seems like the best place for this? But I am not sure. Feel free to move it around as needed.
How should this be tested?
Verification in game - but I haven't spent much time testing or working on WoW addons. So, I'm not sure what your testing process might be.