Paladin blessing threat isn't recorded

[mspk7305]

I had opened an issue on the previous project detailing the problem, pasting it in below as well as a link to the fixed fork I created.

Fixed code:. https://github.com/mspk7305/LibThreatClassic/blob/master/ClassModules/Classic/Paladin.lua

Paladin blessings have a base threat equal to the level the blessing is learned at, for example Greater Blessing of Kings has a base threat of 60, modified by Righteous Fury and further by Improved Righteous Fury to as much as 114 threat per target blessed. This behavior was confirmed by Blizzard in the Oct28 'not a bug' list: https://us.forums.blizzard.com/en/wow/t/wow-classic-not-a-bug-list-updated-10-28-2019/175887/139

A blessing paladin would generate 570 threat if blessing a class with 5 members or 228 if blessing a class with 2 members while under the effect of Improved Righteous Fury, for example. Blessing a class with 5 members 30 times (Onyxia phase 2 example) would yield 17100 threat. This threat would apply to every target in combat with the blessed class.

Please let me know if I can provide any further information Thanks

[dfherr]

Added Blessing threat to LibThreatClassic2. I also cleaned up your code a bit

https://github.com/dfherr/LibThreatClassic2/blob/master/ClassModules/Classic/Paladin.lua#L197-L208

however, I was under the impression reapplying buffs does not generate threat. Only if they are not already present. Do you generate threat by alternating the blessings?

[mspk7305]

Reapplication does indeed generate additional threat since it updates the duration of the buff. Battle shout for warriors does the same thing but is obviously limited to the group. This was my first time writing lua, not surprised I was sloppy. Thanks!

On Sun, Dec 22, 2019, 12:14 PM Dennis-Florian Herr notifications@github.com wrote:

Added Blessing threat to LibThreatClassic2. I also cleaned up your code a bit

https://github.com/dfherr/LibThreatClassic2/blob/master/ClassModules/Classic/Paladin.lua#L197-L208

however, I was under the impression reapplying buffs does not generate threat. Only if they are not already present. Do you generate threat by alternating the blessings?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EsreverWoW/LibThreatClassic/issues/22?email_source=notifications&email_token=AAM57BEESORMCDFCOSQVCXLQZ64AXA5CNFSM4J6ITAXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPX4HI#issuecomment-568294941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM57BF36GKCCTLINKUCW2DQZ64AXANCNFSM4J6ITAXA .