search

EsreverWoW / LibThreatClassic

A library for multi-target threat tracking in WoW Classic (1.13.2).
GNU Lesser General Public License v2.1
8 stars 9 forks source link

Paladin Righteous Fury is ignored #5

Closed twothe closed 5 years ago

twothe commented 5 years ago

I just noticed that in the Paladin class module at line 133 where threat bonus is set when Righteous Fury is active, the value is set to the same value when that buff is gained and lost. I am pretty sure that is a bug.

    if action == "gain" or action == "exist" then
        rfOn = true
        self.isTanking = true
        self.passiveThreatModifiers = 1
    elseif action == "lose" then
        rfOn = false
        self.passiveThreatModifiers = 1
    end
EsreverWoW commented 5 years ago

This is fine, as the variable rfOn is used to set a threat modifier elsewhere in the code by 1.6 (before talents - when talented, it applies that multiplier against it).

cannonpalms commented 4 years ago

Issue migrated to cannonpalms/LibThreatClassic#8