search

EsreverWoW / LibThreatClassic

A library for multi-target threat tracking in WoW Classic (1.13.2).
GNU Lesser General Public License v2.1
8 stars 9 forks source link

Incorrect bit band check #6

Closed MysticalOS closed 5 years ago

MysticalOS commented 5 years ago

bit_band(sourceFlags, COMBATLOG_OBJECT_TYPE_NPC) == COMBATLOG_OBJECT_TYPE_NPC

would never be true. you either want to check if it's equal to 0 or not equal to 0 as far as I can tell. this is basically seeing if bit band for sourceflags using COMBATLOG_OBJECT_TYPE_NPC is equal to COMBATLOG_OBJECT_TYPE_NPC, it wouldn't be.

Same problem with pet and player filters below it. This probably explains why none of the threat modifiers to abilities actually seem to be working right now.

cannonpalms commented 4 years ago

Issue migrated to cannonpalms/LibThreatClassic#9