search

EsreverWoW / LibThreatClassic

A library for multi-target threat tracking in WoW Classic (1.13.2).
GNU Lesser General Public License v2.1
8 stars 9 forks source link

Knock away does not correctly apply threat modifier #7

Closed cannonpalms closed 5 years ago

cannonpalms commented 5 years ago

I see in your commit log that you recently made an attempt to fix Onyxia threat. However, I can confirm that in the current form of this library, Onyxia's Knock Away ability is still not working correctly. In addition to Onyxia's Knock Away, other Knock Away's are also not being handled correctly. No threat change seems to occur when the player is hit with Knock Away.

Details - TinyThreat utilizes this library, however in its previous version -- before https://github.com/EsreverWoW/LibThreatClassic/commit/aab88ebadc8bef562951f8404ac17389be216d1d . It also seems that TinyThreat is handling Knock Away correctly, which leads me to believe that this commit should be reverted. At the very least, more testing is required.

Thanks, Cannon

EDIT: Updated title and comment to reflect that it is not just Onyxia's ability that is currently bugged, it is all Knock Aways.

EsreverWoW commented 5 years ago

I believe this is now fixed. Still need to add in handling for Onyxia's Fireball like we spoke about, but that is a separate issue which requires a bit more investigation.

cannonpalms commented 4 years ago

Issue migrated to cannonpalms/LibThreatClassic#10