cannonpalms
commented
4 years ago Thanks for the PR. Not quite ready for merge, so this PR should be closed and moved to an issue. I'll need to add support for the other abilities modified by improved voidwalker as well, and that will involve some research to determine how threat from sacrifice's absorption shield functions. Additionally, I can't comment on the combat log events from suffering and what we are/are not already handling as far as AoE threat goes; requires a deeper dive and some research.
To the list she goes.
Well, to be fair I don't know much about lua and I don't know much about wow addon scripting, too. But this is my attempt to fix warlocks improved voidwalker talent. At least the Torment spell does now work correctly. Another issue is, that the suffering won't ever be applied to any unit surrounding my void. I think this is because the server doesn't tell exactly who is hit by spell. So how do we make some proper assumptions about which unit is within 10yard range? Perhaps you have an answer for that.