Add referer_url setter - Fix issue #239

Esri / ArcREST

python package for REST API (AGS, AGOL, webmap JSON, etc..)

Apache License 2.0

192 stars 155 forks source link

Closed BrunoCaimar closed 8 years ago

BrunoCaimar commented 8 years ago

I copy and paste setter implementation from AGOLTokenSecurityHandler.

Pls, check if only that is enough to fix this bug (issue #239). I've tested the tool and it worked well.

BrunoCaimar commented 8 years ago

I want to add two things here:

Code duplication - There are some code duplication on security classes. It would be good and easy if you could have only one implementation when possible.
Re-raising exceptions - You are losing some stack details because of it. The error on this issue shows it. Root error is on administration.py and it only shows details about securityhandlerhelper.py.

I hope you can look into it for a next major version :smile:

achapkowski commented 8 years ago

@BrunoCaimar thanks for the code, and the suggestion. I am definitely looking at some code clean up in the base classes.