search

Esri / ArcREST

python package for REST API (AGS, AGOL, webmap JSON, etc..)
Apache License 2.0
192 stars 155 forks source link

Misspelling for geometry filter? #348

Closed geolibrerian closed 7 years ago

geolibrerian commented 7 years ago

ArcRest or ArcRestHelper

ArcRest

Version or date of download

import arcrest arcrest.version '3.5.9'

Bug or Enhancement

At lines 1604 and 1611 of ArcREST/src/arcrest/agol/services.py, the feature layer query geometry filter is defined as "geomtryFilter", instead of "geometryFilter", as defined in the documentation. Note the missing 'e' in geomtryFilter

Documentation: http://esri.github.io/ArcREST/arcrest.agol.html#arcrest.agol.services.FeatureLayer.query

Check here for confirmation https://github.com/Esri/ArcREST/search?utf8=%E2%9C%93&q=geomtry&type=

Repo Steps or Enhancement details

I'm unsure if this misspelling is a bug or not. I'm assuming it is, based on the documentation describing the parameter as geometryFilter.

Thanks a lot for this package. It's a really useful tool!!!

MikeMillerGIS commented 7 years ago

Thanks, since it was just a misspelling of an object, did not affect anything, but fixed it anyways.

geolibrerian commented 7 years ago

Awesome, thanks. I found that it affected my layer queries, as the FeatureLayer objects returned by the FeatureService class relied on that keyword for the geometry filter. I'm glad it's adjusted, and appreciate the quick response!